Skip to content

Conversation

Jonas-Omdal
Copy link
Contributor

Key changes:

  • Replaced moment with Date.
  • Removed the Ready for execution icon and label.
  • If the status do not include STRT it should show a new label and icon.
  • Simplified the component, remove unnecessary props and logic.
    - Renamed the workOrder prop to workOrderId.
    - Add new prop, workOrderType.
    - remove the symbolDirection prop. Symbols should only be displayed in column.

Fixes: #622

@Jonas-Omdal Jonas-Omdal added the bug Something isn't working label Sep 11, 2024
@Jonas-Omdal Jonas-Omdal self-assigned this Sep 11, 2024
@Jonas-Omdal Jonas-Omdal linked an issue Sep 11, 2024 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: e9988ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/mad-dfw Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

HaakonSvane
HaakonSvane previously approved these changes Sep 11, 2024
Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😎 Life is good, code is good 😎 👍

HaakonSvane
HaakonSvane previously approved these changes Sep 11, 2024
Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙 Cool code dude 🤙

Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jonas-Omdal Jonas-Omdal merged commit 7d09c9b into main Sep 11, 2024
3 checks passed
@Jonas-Omdal Jonas-Omdal deleted the 622-improve-the-workordercell-component branch September 11, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the WorkOrderCell component

2 participants