-
Notifications
You must be signed in to change notification settings - Fork 3
fix(workordercell): improve component and fix deviations #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e9988ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 😎 Life is good, code is good 😎 👍
packages/dfw/src/dfwcomponents/WorkOrderCell/WorkOrderCellNavigation.tsx
Show resolved
Hide resolved
2051303
to
9f65808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤙 Cool code dude 🤙
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Key changes:
Ready for execution
icon and label.- Renamed the workOrder prop to workOrderId.
- Add new prop, workOrderType.
- remove the symbolDirection prop. Symbols should only be displayed in column.
Fixes: #622